infoschema,executor: Add CHECK_CONSTRAINTS I_S table #46428

dveeden · 2023-08-25T09:26:45Z

What problem does this PR solve?

This adds the information_schema.CHECK_CONSTRAINTS table similar to what MySQL 8.0 does.

Note that other databases implement this as well:


postgres=# \d information_schema.CHECK_CONSTRAINTS
                       View "information_schema.check_constraints"
       Column       |               Type                | Collation | Nullable | Default 
--------------------+-----------------------------------+-----------+----------+---------
 constraint_catalog | information_schema.sql_identifier |           |          | 
 constraint_schema  | information_schema.sql_identifier |           |          | 
 constraint_name    | information_schema.sql_identifier |           |          | 
 check_clause       | information_schema.character_data |           |          | 

postgres=# SELECT VERSION();
                                                      version                                                      
-------------------------------------------------------------------------------------------------------------------
 PostgreSQL 15.3 (Debian 15.3-0+deb12u1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
(1 row)

Issue Number: close #46427

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The `information_schema.CHECK_CONSTRAINTS` table was added for improved compatibility with MySQL 8.0

ti-chi-bot · 2023-08-25T09:26:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dveeden · 2023-08-25T09:27:02Z

/test all

tiprow · 2023-08-25T09:27:07Z

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-08-25T09:27:33Z

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dveeden · 2023-08-25T09:36:19Z

/ok-to-test

codecov · 2023-08-25T09:57:06Z

Codecov Report

Merging #46428 (7eb2838) into master (2f2bc41) will decrease coverage by 0.7364%.
Report is 131 commits behind head on master.
The diff coverage is 90.9090%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46428        +/-   ##
================================================
- Coverage   73.4051%   72.6687%   -0.7364%     
================================================
  Files          1295       1340        +45     
  Lines        393760     402170      +8410     
================================================
+ Hits         289040     292252      +3212     
- Misses        86355      91372      +5017     
- Partials      18365      18546       +181

Flag	Coverage Δ
integration	`27.8703% <0.0000%> (?)`
unit	`73.2847% <90.9090%> (-0.1204%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`84.9805% <ø> (-0.0828%)`	⬇️
br	`48.1187% <ø> (-4.2017%)`	⬇️

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap).

purelind · 2023-08-28T02:59:08Z

/test pull-integration-prisma-test

tiprow · 2023-08-28T02:59:38Z

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-integration-prisma-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mini256

LGTM, the Prisma Integration Test passed again.

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_integration_prisma_test/detail/pull_integration_prisma_test/2/

ti-chi-bot · 2023-08-28T08:46:30Z

@Mini256: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, the Prisma Integration Test passed again.

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_integration_prisma_test/detail/pull_integration_prisma_test/2/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

executor/infoschema_reader.go

infoschema/test/clustertablestest/tables_test.go

ti-chi-bot · 2023-09-08T06:54:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, Mini256, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mjonss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-08T06:54:59Z

[LGTM Timeline notifier]

Timeline:

2023-08-28 08:22:45.580410874 +0000 UTC m=+1742530.129426861: ☑️ agreed by mjonss.
2023-09-08 06:54:58.784557574 +0000 UTC m=+2687663.333573560: ☑️ agreed by fzzf678.

dveeden · 2023-09-08T07:05:10Z

/retest

infoschema,executor: Add CHECK_CONSTRAINT I_S table

f6e2b56

dveeden requested a review from fzzf678 August 25, 2023 09:30

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 25, 2023

Populate information_schema.CHECK_CONSTRAINTS

73c648c

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2023

dveeden marked this pull request as ready for review August 25, 2023 10:52

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2023

Add test

25bcd6c

dveeden requested review from espresso98, bb7133 and Mini256 August 25, 2023 11:17

Fixup for nogo issue

4e52baf

mjonss approved these changes Aug 28, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2023

djshow832 mentioned this pull request Aug 28, 2023

[DNM] ci: test trigger ci | tidb-test=pr/2204 pingcap/tiproxy#326

Closed

8 tasks

Mini256 approved these changes Aug 28, 2023

View reviewed changes

fzzf678 reviewed Sep 7, 2023

View reviewed changes

executor/infoschema_reader.go Show resolved Hide resolved

infoschema/test/clustertablestest/tables_test.go Show resolved Hide resolved

dveeden added 2 commits September 7, 2023 09:29

Update based on review

ab498cc

Add test for setDataFromCheckConstraints()

d8bf5d3

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023

dveeden added 2 commits September 7, 2023 11:15

Update BUILD.bazel

83e5930

Add license header to infoschema_reader_internal_test.go

7eb2838

fzzf678 approved these changes Sep 8, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023

ti-chi-bot bot merged commit 5f1f0de into pingcap:master Sep 8, 2023

dveeden mentioned this pull request Sep 8, 2023

Add docs for information_schema.CHECK_CONSTRAINTS pingcap/docs#14780

Merged

17 tasks

ran-huang mentioned this pull request Sep 25, 2023

Add docs for information_schema.CHECK_CONSTRAINTS pingcap/docs-cn#15090

Merged

17 tasks

shawn0915 mentioned this pull request Oct 16, 2023

Support TABLE_NAME in CHECK_CONSTRAINTS #47565

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infoschema,executor: Add CHECK_CONSTRAINTS I_S table #46428

infoschema,executor: Add CHECK_CONSTRAINTS I_S table #46428

dveeden commented Aug 25, 2023 •

edited

Loading

ti-chi-bot bot commented Aug 25, 2023

dveeden commented Aug 25, 2023

tiprow bot commented Aug 25, 2023

tiprow bot commented Aug 25, 2023

dveeden commented Aug 25, 2023

codecov bot commented Aug 25, 2023 •

edited

Loading

purelind commented Aug 28, 2023

tiprow bot commented Aug 28, 2023

Mini256 left a comment

ti-chi-bot bot commented Aug 28, 2023

ti-chi-bot bot commented Sep 8, 2023

ti-chi-bot bot commented Sep 8, 2023

dveeden commented Sep 8, 2023

infoschema,executor: Add CHECK_CONSTRAINTS I_S table #46428

infoschema,executor: Add CHECK_CONSTRAINTS I_S table #46428

Conversation

dveeden commented Aug 25, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Aug 25, 2023

dveeden commented Aug 25, 2023

tiprow bot commented Aug 25, 2023

tiprow bot commented Aug 25, 2023

dveeden commented Aug 25, 2023

codecov bot commented Aug 25, 2023 • edited Loading

Codecov Report

purelind commented Aug 28, 2023

tiprow bot commented Aug 28, 2023

Mini256 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 28, 2023

ti-chi-bot bot commented Sep 8, 2023

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

dveeden commented Sep 8, 2023

dveeden commented Aug 25, 2023 •

edited

Loading

codecov bot commented Aug 25, 2023 •

edited

Loading